[Backport 7.72.x] update test that was flakey on windows #42098

dd-octo-sts · 2025-10-17T14:59:57Z

Backport 8310fe0 from #42005.

What does this PR do?

Fixes flakey deployment test on windows

Motivation

=== Failed
=== FAIL: pkg/collector/corechecks/cluster/ksm/customresources TestDeploymentRolloutGeneration_OngoingRollout (0.00s)
    deployment_test.go:101: 
        	Error Trace:	C:/buildroot/datadog-agent/pkg/collector/corechecks/cluster/ksm/customresources/deployment_test.go:101
        	Error:      	&quot;0&quot; is not greater than &quot;0&quot;
        	Test:       	TestDeploymentRolloutGeneration_OngoingRollout
        	Messages:   	Rollout duration should be greater than 0 for ongoing rollout
=== FAIL: pkg/collector/corechecks/cluster/ksm/customresources TestDeploymentRolloutGeneration_OngoingRollout (re-run 1) (0.00s)
    deployment_test.go:101: 
        	Error Trace:	C:/buildroot/datadog-agent/pkg/collector/corechecks/cluster/ksm/customresources/deployment_test.go:101
        	Error:      	&quot;0&quot; is not greater than &quot;0&quot;
        	Test:       	TestDeploymentRolloutGeneration_OngoingRollout
        	Messages:   	Rollout duration should be greater than 0 for ongoing rollout
=== FAIL: pkg/collector/corechecks/cluster/ksm/customresources TestDeploymentRolloutGeneration_OngoingRollout (re-run 2) (0.00s)
    deployment_test.go:101: 
        	Error Trace:	C:/buildroot/datadog-agent/pkg/collector/corechecks/cluster/ksm/customresources/deployment_test.go:101
        	Error:      	&quot;0&quot; is not greater than &quot;0&quot;
        	Test:       	TestDeploymentRolloutGeneration_OngoingRollout
        	Messages:   	Rollout duration should be greater than 0 for ongoing rollout

Describe how you validated your changes

Additional Notes

### What does this PR do? Fixes flakey deployment test on windows ### Motivation ``` === Failed === FAIL: pkg/collector/corechecks/cluster/ksm/customresources TestDeploymentRolloutGeneration_OngoingRollout (0.00s) deployment_test.go:101: Error Trace: C:/buildroot/datadog-agent/pkg/collector/corechecks/cluster/ksm/customresources/deployment_test.go:101 Error: "0" is not greater than "0" Test: TestDeploymentRolloutGeneration_OngoingRollout Messages: Rollout duration should be greater than 0 for ongoing rollout === FAIL: pkg/collector/corechecks/cluster/ksm/customresources TestDeploymentRolloutGeneration_OngoingRollout (re-run 1) (0.00s) deployment_test.go:101: Error Trace: C:/buildroot/datadog-agent/pkg/collector/corechecks/cluster/ksm/customresources/deployment_test.go:101 Error: "0" is not greater than "0" Test: TestDeploymentRolloutGeneration_OngoingRollout Messages: Rollout duration should be greater than 0 for ongoing rollout === FAIL: pkg/collector/corechecks/cluster/ksm/customresources TestDeploymentRolloutGeneration_OngoingRollout (re-run 2) (0.00s) deployment_test.go:101: Error Trace: C:/buildroot/datadog-agent/pkg/collector/corechecks/cluster/ksm/customresources/deployment_test.go:101 Error: "0" is not greater than "0" Test: TestDeploymentRolloutGeneration_OngoingRollout Messages: Rollout duration should be greater than 0 for ongoing rollout ``` ### Describe how you validated your changes ### Additional Notes (cherry picked from commit 8310fe0)

avonengel · 2025-10-23T08:19:23Z

/merge

dd-devflow-routing-codex · 2025-10-23T08:19:27Z

View all feedbacks in Devflow UI.

2025-10-23 08:19:27 UTC ℹ️ Start processing command /merge

2025-10-23 08:19:34 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-23 08:29:46 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

AliDatadog · 2025-10-23T08:29:39Z

/remove

dd-devflow-routing-codex · 2025-10-23T08:29:43Z

View all feedbacks in Devflow UI.

2025-10-23 08:29:42 UTC ℹ️ Start processing command /remove

2025-10-23 08:29:44 UTC ℹ️ Devflow: /remove

lavigne958 · 2025-10-23T09:53:16Z

not ciritical backport, closing this PR

frank-spano · 2025-10-23T13:08:10Z

/merge

dd-devflow-routing-codex · 2025-10-23T13:08:15Z

View all feedbacks in Devflow UI.

2025-10-23 13:08:15 UTC ℹ️ Start processing command /merge

2025-10-23 13:08:17 UTC ❌ MergeQueue

You are not allowed to use the merge queue towards 7.72.x. User is not part of the authorized users or teams.
The authorized teams (including their child teams) are: agent-supply-chain.

AliDatadog · 2025-10-23T14:01:44Z

/merge

dd-devflow-routing-codex · 2025-10-23T14:01:48Z

View all feedbacks in Devflow UI.

2025-10-23 14:01:48 UTC ℹ️ Start processing command /merge

2025-10-23 14:01:54 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in 7.72.x is approximately 46m (p90).

2025-10-23 14:04:17 UTC 🚨 MergeQueue: This merge request is in error because of GitLab

Gitlab pipeline didn't start... Please retry.

you can get help from #ci-infra-support

Error: gitlab pipeline not started

agent-platform-auto-pr · 2025-10-23T14:13:09Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d194c2e

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	DataNotFound	$${701.0}$$ < $${703.13}$$	DataNotFound	$${176.83}$$ < $${178.38}$$
✅	agent_deb_amd64_fips	DataNotFound	$${695.5}$$ < $${697.61}$$	DataNotFound	$${175.57}$$ < $${177.15}$$
✅	agent_heroku_amd64	DataNotFound	$${339.27}$$ < $${341.62}$$	DataNotFound	$${90.13}$$ < $${91.52}$$
✅	agent_msi	DataNotFound	$${984.61}$$ < $${990.42}$$	DataNotFound	$${149.87}$$ < $${152.42}$$
✅	agent_rpm_amd64	DataNotFound	$${700.99}$$ < $${703.12}$$	DataNotFound	$${180.05}$$ < $${180.53}$$
✅	agent_rpm_amd64_fips	DataNotFound	$${695.49}$$ < $${697.6}$$	DataNotFound	$${177.87}$$ < $${178.87}$$
✅	agent_rpm_arm64	DataNotFound	$${685.15}$$ < $${689.82}$$	DataNotFound	$${160.25}$$ < $${162.16}$$
✅	agent_rpm_arm64_fips	DataNotFound	$${680.67}$$ < $${685.08}$$	DataNotFound	$${159.21}$$ < $${161.11}$$
✅	agent_suse_amd64	DataNotFound	$${700.99}$$ < $${703.12}$$	DataNotFound	$${180.05}$$ < $${180.53}$$
✅	agent_suse_amd64_fips	DataNotFound	$${695.49}$$ < $${697.6}$$	DataNotFound	$${177.87}$$ < $${178.87}$$
✅	agent_suse_arm64	DataNotFound	$${685.15}$$ < $${689.82}$$	DataNotFound	$${160.25}$$ < $${162.16}$$
✅	agent_suse_arm64_fips	DataNotFound	$${680.67}$$ < $${685.08}$$	DataNotFound	$${159.21}$$ < $${161.11}$$
✅	docker_agent_amd64	DataNotFound	$${772.44}$$ < $${774.54}$$	DataNotFound	$${265.07}$$ < $${266.46}$$
✅	docker_agent_arm64	DataNotFound	$${780.54}$$ < $${785.2}$$	DataNotFound	$${250.87}$$ < $${252.92}$$
✅	docker_agent_jmx_amd64	DataNotFound	$${963.3}$$ < $${965.41}$$	DataNotFound	$${333.71}$$ < $${335.08}$$
✅	docker_agent_jmx_arm64	DataNotFound	$${960.01}$$ < $${964.66}$$	DataNotFound	$${315.48}$$ < $${317.54}$$
✅	docker_cluster_agent_amd64	DataNotFound	$${212.82}$$ < $${213.74}$$	DataNotFound	$${72.2}$$ < $${73.2}$$
✅	docker_cluster_agent_arm64	DataNotFound	$${228.73}$$ < $${229.68}$$	DataNotFound	$${68.47}$$ < $${69.48}$$
✅	docker_cws_instrumentation_amd64	DataNotFound	$${7.07}$$ < $${7.12}$$	DataNotFound	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	DataNotFound	$${6.69}$$ < $${6.92}$$	DataNotFound	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	DataNotFound	$${38.36}$$ < $${39.3}$$	DataNotFound	$${14.82}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	DataNotFound	$${37.06}$$ < $${37.94}$$	DataNotFound	$${14.26}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	DataNotFound	$${29.58}$$ < $${30.53}$$	DataNotFound	$${7.8}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	DataNotFound	$${28.17}$$ < $${29.12}$$	DataNotFound	$${6.76}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	DataNotFound	$${29.58}$$ < $${30.53}$$	DataNotFound	$${7.81}$$ < $${8.77}$$
✅	dogstatsd_suse_amd64	DataNotFound	$${29.58}$$ < $${30.53}$$	DataNotFound	$${7.81}$$ < $${8.77}$$
✅	iot_agent_deb_amd64	DataNotFound	$${54.51}$$ < $${54.97}$$	DataNotFound	$${13.63}$$ < $${14.45}$$
✅	iot_agent_deb_arm64	DataNotFound	$${51.8}$$ < $${51.9}$$	DataNotFound	$${11.75}$$ < $${12.63}$$
✅	iot_agent_deb_armhf	DataNotFound	$${51.33}$$ < $${51.84}$$	DataNotFound	$${11.82}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	DataNotFound	$${54.51}$$ < $${54.97}$$	DataNotFound	$${13.64}$$ < $${14.47}$$
✅	iot_agent_suse_amd64	DataNotFound	$${54.51}$$ < $${54.97}$$	DataNotFound	$${13.64}$$ < $${14.47}$$

AliDatadog · 2025-10-28T09:19:38Z

/merge

dd-devflow-routing-codex · 2025-10-28T09:19:42Z

View all feedbacks in Devflow UI.

2025-10-28 09:19:42 UTC ℹ️ Start processing command /merge

2025-10-28 09:19:49 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-28 09:20:17 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in 7.72.x is approximately 46m (p90).

2025-10-28 09:41:23 UTC ℹ️ MergeQueue: This merge request was merged

cit-pr-commenter · 2025-10-28T10:22:05Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 770f6eac-b30d-44f8-a779-f0df28040f88

Baseline: 0f6275b
Comparison: ff8ef65
Diff

Optimization Goals: ✅ Improvement(s) detected

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
✅	docker_containers_memory	memory utilization	-7.98	[-8.38, -7.58]	1	Logs

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
✅	docker_containers_cpu	% cpu utilization	-28.67	[-29.63, -27.70]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_metrics_logs	memory utilization	+1.36	[+1.15, +1.58]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.55	[+0.35, +0.75]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.23	[+0.19, +0.27]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.18	[+0.14, +0.21]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	+0.15	[-0.01, +0.32]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.05	[+0.01, +0.10]	1	Logs
➖	file_tree	memory utilization	+0.04	[+0.00, +0.08]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.59, +0.58]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.01	[-0.65, +0.63]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.24, +0.21]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.03	[-0.63, +0.56]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.07	[-0.66, +0.52]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.12	[-0.27, +0.03]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.15	[-0.27, -0.03]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.24	[-0.36, -0.12]	1	Logs
➖	ddot_logs	memory utilization	-0.26	[-0.31, -0.21]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.54	[-0.66, -0.41]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.58	[-0.65, -0.51]	1	Logs
➖	quality_gate_logs	% cpu utilization	-1.29	[-4.10, +1.52]	1	Logs bounds checks dashboard
✅	docker_containers_memory	memory utilization	-7.98	[-8.38, -7.58]	1	Logs
✅	docker_containers_cpu	% cpu utilization	-28.67	[-29.63, -27.70]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
❌	docker_containers_memory	memory_usage	9/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

dd-octo-sts bot requested a review from a team as a code owner October 17, 2025 14:59

dd-octo-sts bot added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests backport bot short review PR is simple enough to be reviewed quickly team/container-integrations labels Oct 17, 2025

lavigne958 approved these changes Oct 20, 2025

View reviewed changes

lavigne958 closed this Oct 23, 2025

frank-spano reopened this Oct 23, 2025

Merge branch '7.72.x' into backport-42005-to-7.72.x

ff8ef65

dd-mergequeue bot merged commit 0fc20aa into 7.72.x Oct 28, 2025
158 of 183 checks passed

dd-mergequeue bot deleted the backport-42005-to-7.72.x branch October 28, 2025 09:41

github-actions bot added this to the 7.72.0 milestone Oct 28, 2025

[Backport 7.72.x] update test that was flakey on windows #42098

[Backport 7.72.x] update test that was flakey on windows #42098

Conversation

dd-octo-sts bot commented Oct 17, 2025

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

avonengel commented Oct 23, 2025

Uh oh!

dd-devflow-routing-codex bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AliDatadog commented Oct 23, 2025

Uh oh!

dd-devflow-routing-codex bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lavigne958 commented Oct 23, 2025

Uh oh!

frank-spano commented Oct 23, 2025

Uh oh!

dd-devflow-routing-codex bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AliDatadog commented Oct 23, 2025

Uh oh!

dd-devflow-routing-codex bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agent-platform-auto-pr bot commented Oct 23, 2025

Static quality checks

Info

Uh oh!

AliDatadog commented Oct 28, 2025

Uh oh!

dd-devflow-routing-codex bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cit-pr-commenter bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ Improvement(s) detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dd-devflow-routing-codex bot commented Oct 23, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Oct 23, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Oct 23, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Oct 23, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Oct 28, 2025 •

edited

Loading

cit-pr-commenter bot commented Oct 28, 2025 •

edited

Loading